Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 14456002: Change safely-roll-webkit to safely-roll-blink. (Closed)

Created:
7 years, 8 months ago by ojan
Modified:
7 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Change safely-roll-webkit to safely-roll-blink. s/WebKit/Blink and update the revision range URL to point to Blink revisions instead of trac.webkit.org. Also added a --dry-run so that I could run this without actually modifying my tree and making a patch. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195987

Patch Set 1 #

Total comments: 1

Patch Set 2 : Now with right default #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -128 lines) Patch
A + tools/safely-roll-blink.py View 1 5 chunks +27 lines, -14 lines 1 comment Download
D tools/safely-roll-webkit.py View 1 chunk +0 lines, -114 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ojan
7 years, 8 months ago (2013-04-23 23:25:25 UTC) #1
ojan
7 years, 8 months ago (2013-04-23 23:25:34 UTC) #2
M-A Ruel
https://codereview.chromium.org/14456002/diff/1/tools/safely-roll-blink.py File tools/safely-roll-blink.py (right): https://codereview.chromium.org/14456002/diff/1/tools/safely-roll-blink.py#newcode49 tools/safely-roll-blink.py:49: parser.add_option('--dry-run', action='store_true', default=True) You are sure about the default?
7 years, 8 months ago (2013-04-24 00:55:37 UTC) #3
ojan
On 2013/04/24 00:55:37, Marc-Antoine Ruel wrote: > https://codereview.chromium.org/14456002/diff/1/tools/safely-roll-blink.py > File tools/safely-roll-blink.py (right): > > https://codereview.chromium.org/14456002/diff/1/tools/safely-roll-blink.py#newcode49 ...
7 years, 8 months ago (2013-04-24 01:10:17 UTC) #4
ojan
Fixed.
7 years, 8 months ago (2013-04-24 01:16:25 UTC) #5
M-A Ruel
(Added NOTRY=true) lgtm https://codereview.chromium.org/14456002/diff/5001/tools/safely-roll-blink.py File tools/safely-roll-blink.py (right): https://codereview.chromium.org/14456002/diff/5001/tools/safely-roll-blink.py#newcode49 tools/safely-roll-blink.py:49: parser.add_option('--dry-run', action='store_true', default=False) Personally, I prefer ...
7 years, 8 months ago (2013-04-24 01:40:23 UTC) #6
ojan
7 years, 8 months ago (2013-04-24 01:54:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r195987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698