Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1445523003: Revert of Switch uses of SkChecksum::Compute to Murmur3. (Closed)

Created:
5 years, 1 month ago by mtklein
Modified:
5 years, 1 month ago
Reviewers:
bsalomon, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch uses of SkChecksum::Compute to Murmur3. (patchset #2 id:20001 of https://codereview.chromium.org/1436973003/ ) Reason for revert: I would not have expected this to change any images. Looks like it's changed both MSAA and non-MSAA GMs: https://gold.skia.org/search2?blame=1d024a3c909ae5cefa5e8b339e2b52dc73ee85ac&unt=true&head=true&query=source_type%3Dgm Original issue's description: > Switch uses of SkChecksum::Compute to Murmur3. > > SkChecksum::Compute is a very, very poorly distributed hash function. > This replaces all remaining uses with Murmur3. > > The only interesting stuff is in src/gpu. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/1d024a3c909ae5cefa5e8b339e2b52dc73ee85ac TBR=bsalomon@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0274efbd3d2c3b2fba2b4212347159a20050038d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -8 lines) Patch
M bench/ChecksumBench.cpp View 4 chunks +9 lines, -0 lines 0 comments Download
M include/private/SkChecksum.h View 3 chunks +89 lines, -0 lines 0 comments Download
M src/core/SkPictureFlat.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrResourceCache.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/ChecksumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Switch uses of SkChecksum::Compute to Murmur3.
5 years, 1 month ago (2015-11-13 15:07:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445523003/1
5 years, 1 month ago (2015-11-13 15:07:43 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 15:07:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0274efbd3d2c3b2fba2b4212347159a20050038d

Powered by Google App Engine
This is Rietveld 408576698