Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1445523002: Revert of Disable platform-mode to try and green up tests. (Closed)

Created:
5 years, 1 month ago by ghost stip (do not use)
Modified:
5 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, darin-cc_chromium.org, jam, M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable platform-mode to try and green up tests. (patchset #1 id:1 of https://codereview.chromium.org/1445503002/ ) Reason for revert: didn't seem to help https://build.chromium.org/p/chromium.swarm/builders/Android%20Swarm/builds/3775 Original issue's description: > Disable platform-mode to try and green up tests. > > BUG=525873 > R=jbudorick@chromium.org > TBR=jbudorick@chromium.org > NOTRY=True > CC=maruel@chromium.org > > Committed: https://crrev.com/49b3d93eac886e0fe953b2a3db12c96d99e6ee9e > Cr-Commit-Position: refs/heads/master@{#359522} TBR=jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=525873 Committed: https://crrev.com/dee5163a66d0842b1aea4da2d97c66b7afd4e73c Cr-Commit-Position: refs/heads/master@{#359530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/chrome_public_test_apk.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/chrome_sync_shell_test_apk.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell_test_apk_run.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ghost stip (do not use)
Created Revert of Disable platform-mode to try and green up tests.
5 years, 1 month ago (2015-11-13 10:32:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445523002/1
5 years, 1 month ago (2015-11-13 10:32:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 10:33:02 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 10:33:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dee5163a66d0842b1aea4da2d97c66b7afd4e73c
Cr-Commit-Position: refs/heads/master@{#359530}

Powered by Google App Engine
This is Rietveld 408576698