Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1445513002: [turbofan] Introduce JSCallReducer to strength reduce JSCallFunction nodes. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce JSCallReducer to strength reduce JSCallFunction nodes. The JSCallReducer runs together with inlining and tries to strength reduce JSCallFunction nodes; currently it can fold Function.prototype.call and Function.prototype.apply (with arguments), and make it possible to inline across them. In the case of Function.prototype.apply with arguments we still have to leave the JSCreateArguments node in the graph because there might be other (frame state) uses. Once escape analysis is ready, it will take care of removing these nodes and adding appropriate transitions for the deoptimizer. R=jarin@chromium.org BUG=v8:4551 LOG=n Committed: https://crrev.com/55c07a8b2f9c88f4429cd22100d520a5cf24c567 Cr-Commit-Position: refs/heads/master@{#31979}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix win compile. #

Patch Set 3 : Comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -51 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 4 chunks +0 lines, -43 lines 0 comments Download
A src/compiler/js-call-reducer.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A src/compiler/js-call-reducer.cc View 1 1 chunk +187 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/type-feedback-vector.h View 3 chunks +8 lines, -6 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-13 10:29:36 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the initial implementation of the idea I told you about before. It ...
5 years, 1 month ago (2015-11-13 10:30:56 UTC) #2
Jarin
lgtm, but I am wondering whether we should test this. https://codereview.chromium.org/1445513002/diff/1/src/compiler/js-call-reducer.h File src/compiler/js-call-reducer.h (right): https://codereview.chromium.org/1445513002/diff/1/src/compiler/js-call-reducer.h#newcode20 ...
5 years, 1 month ago (2015-11-13 10:56:56 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1445513002/diff/1/src/compiler/js-call-reducer.h File src/compiler/js-call-reducer.h (right): https://codereview.chromium.org/1445513002/diff/1/src/compiler/js-call-reducer.h#newcode20 src/compiler/js-call-reducer.h:20: // inlining or other optimizations to perform further optimizations ...
5 years, 1 month ago (2015-11-13 11:32:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445513002/40001
5 years, 1 month ago (2015-11-13 11:33:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-13 12:19:41 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:22 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55c07a8b2f9c88f4429cd22100d520a5cf24c567
Cr-Commit-Position: refs/heads/master@{#31979}

Powered by Google App Engine
This is Rietveld 408576698