Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 14455012: cros: Enable new cras audio handler by default (Closed)

Created:
7 years, 7 months ago by James Cook
Modified:
7 years, 7 months ago
Reviewers:
stevenjb, jennyz
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, chihchung, rkc
Visibility:
Public.

Description

cros: Enable new cras audio handler by default Add separate flag for audio device switcher menu, off by default BUG=160311 TEST=Audio input/output/mute still works

Patch Set 1 #

Total comments: 1

Patch Set 2 : separate flag for UI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -22 lines) Patch
M ash/ash_switches.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download
M ash/system/chromeos/audio/tray_audio.cc View 1 3 chunks +11 lines, -4 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
James Cook
Steven, PTAL https://codereview.chromium.org/14455012/diff/1/ash/test/ash_test_helper.cc File ash/test/ash_test_helper.cc (right): https://codereview.chromium.org/14455012/diff/1/ash/test/ash_test_helper.cc#newcode50 ash/test/ash_test_helper.cc:50: CommandLine::ForCurrentProcess()->AppendSwitch( I talked to Oshima about this ...
7 years, 7 months ago (2013-04-29 23:41:16 UTC) #1
stevenjb
lgtm
7 years, 7 months ago (2013-04-29 23:45:28 UTC) #2
James Cook
+jennyz,dgreid just FYI
7 years, 7 months ago (2013-04-29 23:50:26 UTC) #3
James Cook
On 2013/04/29 23:50:26, James Cook (Chromium) wrote: > +jennyz,dgreid just FYI With this on by ...
7 years, 7 months ago (2013-04-30 00:02:11 UTC) #4
jennyz
lgtm
7 years, 7 months ago (2013-04-30 03:27:18 UTC) #5
jennyz
On 2013/04/29 23:50:26, James Cook (Chromium) wrote: > +jennyz,dgreid just FYI dgreid@ and chihchung@, please ...
7 years, 7 months ago (2013-04-30 03:31:00 UTC) #6
dgreid
On 2013/04/30 03:31:00, jennyz wrote: > On 2013/04/29 23:50:26, James Cook (Chromium) wrote: > > ...
7 years, 7 months ago (2013-04-30 04:20:47 UTC) #7
James Cook
steven, PTAL - I added a separate flag for the UI, off by default We ...
7 years, 7 months ago (2013-04-30 17:43:24 UTC) #8
stevenjb
LGTM
7 years, 7 months ago (2013-04-30 17:45:52 UTC) #9
jennyz
ltgm. Thanks!
7 years, 7 months ago (2013-04-30 18:22:54 UTC) #10
James Cook
7 years, 7 months ago (2013-05-01 17:00:42 UTC) #11
On 2013/04/30 18:22:54, jennyz wrote:
> ltgm. Thanks!

Taken over by rkc@ at https://codereview.chromium.org/14678004/

Powered by Google App Engine
This is Rietveld 408576698