Issue 14455004: HConstant::InNewSpace() should be a constant function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14455004: HConstant::InNewSpace() should be a constant function (Closed)

Created:
7 years, 8 months ago by mvstanton

Modified:
7 years, 7 months ago

Reviewers:
Michael Starzinger, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

HConstant::InNewSpace() should be a constant function BUG= Committed: https://code.google.com/p/v8/source/detail?r=14466

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	src/hydrogen-instructions.h	View		3 chunks	+12 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Committed patchset #1 manually as r14466 (presubmit successful).

7 years, 8 months ago (2013-04-26 15:48:18 UTC) #3

Michael Starzinger

7 years, 7 months ago (2013-04-29 11:16:44 UTC) #4

Message was sent while issue was closed.

Drive-by comment.

https://codereview.chromium.org/14455004/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/14455004/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:3414: static PretenureFlag pretenure() { return
TENURED; }
I don't understand this function, wouldn't a comment in the handle() accessor
suffice? Also why place this function between "handle_" and the comment that
explains "handle_"? Can we drop this function?

Expand Messages | Collapse Messages