Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 144543005: Allow to enable/disable inline allocation via runtime function. (Closed)

Created:
6 years, 11 months ago by Michael Achenbach
Modified:
6 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Allow to enable/disable inline allocation via runtime function. This will allow to artificially trigger GCs on all allocations for testing purposes. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18787

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/heap.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
6 years, 11 months ago (2014-01-23 15:43:26 UTC) #1
Michael Starzinger
LGTM with comment. https://codereview.chromium.org/144543005/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/144543005/diff/1/src/runtime.cc#newcode8757 src/runtime.cc:8757: isolate->heap()->EnableInlineAllocation(); As discussed offline: We could ...
6 years, 11 months ago (2014-01-23 15:52:18 UTC) #2
Michael Achenbach
On 2014/01/23 15:52:18, Michael Starzinger wrote: > LGTM with comment. > > https://codereview.chromium.org/144543005/diff/1/src/runtime.cc > File ...
6 years, 11 months ago (2014-01-23 15:55:43 UTC) #3
Michael Achenbach
6 years, 11 months ago (2014-01-23 15:57:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698