Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1445383002: Remove unused instr_action == 'instrument_classes' option from emma_instr.py (Closed)

Created:
5 years, 1 month ago by pkotwicz
Modified:
5 years, 1 month ago
Reviewers:
agrieve
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused instr_action == 'instrument_classes' option from emma_instr.py BUG=535290 Committed: https://crrev.com/5a353f01b5df17dbb8ccd73485b5253105d28d0d Cr-Commit-Position: refs/heads/master@{#360164}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -33 lines) Patch
M build/android/emma_instr_action.gypi View 2 chunks +1 line, -8 lines 0 comments Download
M build/android/gyp/emma_instr.py View 1 5 chunks +8 lines, -23 lines 0 comments Download
M build/java.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/java_apk.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
pkotwicz
Andrew, can you please take a look?
5 years, 1 month ago (2015-11-17 04:21:23 UTC) #5
agrieve
On 2015/11/17 04:21:23, pkotwicz wrote: > Andrew, can you please take a look? lgtm
5 years, 1 month ago (2015-11-17 15:24:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445383002/40001
5 years, 1 month ago (2015-11-17 19:48:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445383002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445383002/80001
5 years, 1 month ago (2015-11-17 20:14:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445383002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445383002/80001
5 years, 1 month ago (2015-11-17 20:57:14 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 1 month ago (2015-11-17 21:28:38 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 21:29:29 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5a353f01b5df17dbb8ccd73485b5253105d28d0d
Cr-Commit-Position: refs/heads/master@{#360164}

Powered by Google App Engine
This is Rietveld 408576698