Issue 1445363002: Embedded options discovery (#24943).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1445363002: Embedded options discovery (#24943). (Closed)

Created:
5 years, 1 month ago by pquitslund

Modified:
5 years, 1 month ago

Reviewers:
Cutch, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Embedded options discovery (#24943). Merges analysis options extracted from `_embedder.yaml` files (potentially) with local overrides. Background: https://github.com/dart-lang/sdk/issues/24943 For test coverage of merging, see: `analyzer/test/src/util/yaml_test.dart`. BUG=24943 R=brianwilkerson@google.com, johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/3a1a3ee0948f0bfe6b3d36c49b5e8eb0dfb1b8b1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+213 lines, -106 lines)			Patch
M	pkg/analysis_server/lib/src/context_manager.dart	View	5 chunks	+36 lines, -9 lines	0 comments	Download
M	pkg/analysis_server/test/context_manager_test.dart	View	5 chunks	+130 lines, -56 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/options.dart	View	4 chunks	+47 lines, -41 lines	0 comments	Download

Total messages: 5 (1 generated)

pquitslund

5 years, 1 month ago (2015-11-19 00:41:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3a1a3ee0948f0bfe6b3d36c49b5e8eb0dfb1b8b1 (presubmit successful).