Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1445343002: De-spam SkOpts.cpp (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

De-spam SkOpts.cpp - stop printing when we detect sse4.2 and avx2 - that TODO is pretty well done BUG=skia: Committed: https://skia.googlesource.com/skia/+/ee9fe1e6f39a37d522ea700873b0e5c08f0c6674

Patch Set 1 #

Patch Set 2 : no static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/core/SkOpts.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445343002/1
5 years, 1 month ago (2015-11-17 00:15:53 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/2554) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 1 month ago (2015-11-17 00:16:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445343002/20001
5 years, 1 month ago (2015-11-17 00:19:44 UTC) #7
mtklein_C
5 years, 1 month ago (2015-11-17 00:22:15 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 00:31:06 UTC) #11
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-17 00:33:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445343002/20001
5 years, 1 month ago (2015-11-17 01:28:08 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 01:28:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ee9fe1e6f39a37d522ea700873b0e5c08f0c6674

Powered by Google App Engine
This is Rietveld 408576698