Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 144533005: More cctest fixes regarding lifetime/ownership. (Closed)

Created:
6 years, 10 months ago by Sven Panne
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

More cctest fixes regarding lifetime/ownership. * Avoid double-free in cctest/test-api/RegExpInterruption. * Avoid incorrect zone fiddling in cctest/test-strings. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19020

Patch Set 1 #

Patch Set 2 : Disable isolate disposal at end of cctest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -43 lines) Patch
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-strings.cc View 14 chunks +29 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 10 months ago (2014-01-31 13:24:49 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-01-31 13:27:27 UTC) #2
Sven Panne
6 years, 10 months ago (2014-02-03 07:29:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19020 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698