DescriptionUse subtle::NoBarrier* statements for Histogram flags_ field.
This is similar to this CL which provided the same treatment to
some of the other histogram internal fields:
https://codereview.chromium.org/116983004
This field can be accessed from multiple threads which causes
TSAN to report data races. Using NoBarrier instructions makes
this intention explicit and silences the TSAN errors.
Here's some context for the data race and why it's harmless:
https://code.google.com/p/chromium/issues/detail?id=535359#c14
BUG=535359
Committed: https://crrev.com/a74e3d57c0c1feebb1f0bf28a4dfaea03b3734d2
Cr-Commit-Position: refs/heads/master@{#360723}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 18 (4 generated)
|