Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: pkg/analyzer/lib/src/generated/source.dart

Issue 1445283003: Log unresolved URIs using 'logInformation', so don't send to IDE. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library engine.source; 5 library engine.source;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 import "dart:math" as math; 8 import "dart:math" as math;
9 9
10 import 'package:analyzer/file_system/file_system.dart'; 10 import 'package:analyzer/file_system/file_system.dart';
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 if (containedUri == null || containedUri.isEmpty) { 736 if (containedUri == null || containedUri.isEmpty) {
737 return null; 737 return null;
738 } 738 }
739 try { 739 try {
740 // Force the creation of an escaped URI to deal with spaces, etc. 740 // Force the creation of an escaped URI to deal with spaces, etc.
741 return _internalResolveUri( 741 return _internalResolveUri(
742 containingSource, parseUriWithException(containedUri)); 742 containingSource, parseUriWithException(containedUri));
743 } catch (exception, stackTrace) { 743 } catch (exception, stackTrace) {
744 String containingFullName = 744 String containingFullName =
745 containingSource != null ? containingSource.fullName : '<null>'; 745 containingSource != null ? containingSource.fullName : '<null>';
746 AnalysisEngine.instance.logger.logError( 746 AnalysisEngine.instance.logger.logInformation(
747 "Could not resolve URI ($containedUri) relative to source ($containing FullName)", 747 "Could not resolve URI ($containedUri) relative to source ($containing FullName)",
748 new CaughtException(exception, stackTrace)); 748 new CaughtException(exception, stackTrace));
749 return null; 749 return null;
750 } 750 }
751 } 751 }
752 752
753 /** 753 /**
754 * Return an absolute URI that represents the given source, or `null` if a val id URI cannot 754 * Return an absolute URI that represents the given source, or `null` if a val id URI cannot
755 * be computed. 755 * be computed.
756 * 756 *
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
1077 Source resolveAbsolute(Uri uri, [Uri actualUri]); 1077 Source resolveAbsolute(Uri uri, [Uri actualUri]);
1078 1078
1079 /** 1079 /**
1080 * Return an absolute URI that represents the given [source], or `null` if a 1080 * Return an absolute URI that represents the given [source], or `null` if a
1081 * valid URI cannot be computed. 1081 * valid URI cannot be computed.
1082 * 1082 *
1083 * The computation should be based solely on [source.fullName]. 1083 * The computation should be based solely on [source.fullName].
1084 */ 1084 */
1085 Uri restoreAbsolute(Source source) => null; 1085 Uri restoreAbsolute(Source source) => null;
1086 } 1086 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698