Issue 1445273002: Revert "Use FunctionElementImpl for inline function type parameters"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1445273002: Revert "Use FunctionElementImpl for inline function type parameters" (Closed)

Created:
5 years, 1 month ago by Jennifer Messerly

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Use FunctionElementImpl for inline function type parameters" This reverts commit 79de8d80935fd123a95e71404ed3190676f95868. Committed: https://github.com/dart-lang/sdk/commit/2990a0933af711a0b7d964debeb222dd130477c2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -46 lines)			Patch
M	pkg/analyzer/lib/src/generated/element.dart	View	2 chunks	+18 lines, -9 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+27 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	2 chunks	+10 lines, -31 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

TBR. Reverting for further investigation, but I think we just lost track of the pruned ...

5 years, 1 month ago (2015-11-16 22:39:14 UTC) #2

Jennifer Messerly

Committed patchset #1 (id:1) manually as 2990a0933af711a0b7d964debeb222dd130477c2 (presubmit successful).

5 years, 1 month ago (2015-11-16 22:40:15 UTC) #3

Message was sent while issue was closed.

LGTM