Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

Issue 1445233002: Schedule an early upload of non-JNI Java crashes Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync / rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
index 2ce4ea1c6d35ad8a97a9f907daa54ff548c2be56..8f8ac05dd96ca8432f82c50b2ad604ed6c039ae7 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
@@ -338,6 +338,31 @@ public class MinidumpUploadServiceTest extends CrashTestCase {
*/
@SmallTest
@Feature({"Android-AppBase"})
+ public void testTryUploadLastCrashDumpHelperMethod() {
+ // Setup prerequisites.
+ final String startServiceFlag = "startServiceFlag";
+ MinidumpPreparationContext context = new MinidumpPreparationContext(
+ getInstrumentation().getTargetContext()) {
+ @Override
+ public ComponentName startService(Intent intentToCheck) {
+ assertEquals(MinidumpUploadService.ACTION_FIND_LAST, intentToCheck.getAction());
+ setFlag(startServiceFlag);
+ return new ComponentName(getPackageName(), MinidumpUploadService.class.getName());
+ }
+ };
+
+ // Run test.
+ MinidumpUploadService.tryUploadLastCrashDump(context);
+
+ // Verify.
+ assertTrue("Should have called startService(...)", context.isFlagSet(startServiceFlag));
+ }
+
+ /**
+ * This tests how we instantiate crash uploading from Main, so it is just a sanity check.
+ */
+ @SmallTest
+ @Feature({"Android-AppBase"})
public void testTryUploadAllCrashDumpsHelperMethod() {
// Setup prerequisites.
final String startServiceFlag = "startServiceFlag";

Powered by Google App Engine
This is Rietveld 408576698