code cleanup for power monitoring

code cleanup for power monitoring

resubmit to fix bug with previous cl

BUG=556653
Committed: https://crrev.com/2d9a50a5beda147c8e4c8e9c86dee550b19ecc4e
Cr-Commit-Position: refs/heads/master@{#359977}

[alexandermont, 2015-11-16 19:37:44]

alexandermont@chromium.org changed reviewers:
+ nednguyen@google.com, rnephew@chromium.org

[alexandermont, 2015-11-16 19:37:45]

Re-upload of power monitoring CL to fix bug 556653.

[rnephew (Wrong account), 2015-11-16 19:43:30]

rnephew@google.com changed reviewers:
+ rnephew@google.com

[rnephew (Wrong account), 2015-11-16 19:43:31]

https://codereview.chromium.org/1445203003/diff/1/tools/telemetry/telemetry/i...
File
tools/telemetry/telemetry/internal/platform/power_monitor/cros_power_monitor.py
(right):

https://codereview.chromium.org/1445203003/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/power_monitor/cros_power_monitor.py:36:
self._CheckStart()
Actually something I didn't catch last review, this has to call super() because
it runs the sysfs_power_monitor code. Add that back, and get rid of
self._CheckStart() since that power monitor already calls it.

[rnephew (Wrong account), 2015-11-16 21:27:56]

On 2015/11/16 19:43:31, rnephew wrote:
>
https://codereview.chromium.org/1445203003/diff/1/tools/telemetry/telemetry/i...
> File
>
tools/telemetry/telemetry/internal/platform/power_monitor/cros_power_monitor.py
> (right):
> 
>
https://codereview.chromium.org/1445203003/diff/1/tools/telemetry/telemetry/i...
>
tools/telemetry/telemetry/internal/platform/power_monitor/cros_power_monitor.py:36:
> self._CheckStart()
> Actually something I didn't catch last review, this has to call super()
because
> it runs the sysfs_power_monitor code. Add that back, and get rid of
> self._CheckStart() since that power monitor already calls it.

lgtm, wait for Ned's approval though.

[alexandermont, 2015-11-16 21:40:00]

alexandermont@chromium.org changed reviewers:
- rnephew@google.com

[alexandermont, 2015-11-16 21:40:00]

publish comments

https://codereview.chromium.org/1445203003/diff/1/tools/telemetry/telemetry/i...
File
tools/telemetry/telemetry/internal/platform/power_monitor/cros_power_monitor.py
(right):

https://codereview.chromium.org/1445203003/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/platform/power_monitor/cros_power_monitor.py:36:
self._CheckStart()
On 2015/11/16 at 19:43:31, rnephew wrote:
> Actually something I didn't catch last review, this has to call super()
because it runs the sysfs_power_monitor code. Add that back, and get rid of
self._CheckStart() since that power monitor already calls it.

Done.

[nednguyen, 2015-11-16 21:40:41]

lgtm

[alexandermont, 2015-11-16 22:09:07]

The CQ bit was checked by alexandermont@chromium.org

[commit-bot: I haz the power, 2015-11-16 22:09:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1445203003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1445203003/20001

[commit-bot: I haz the power, 2015-11-17 02:25:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-17 02:26:27]

Patchset 2 (id:??) landed as
https://crrev.com/2d9a50a5beda147c8e4c8e9c86dee550b19ecc4e
Cr-Commit-Position: refs/heads/master@{#359977}