 Chromium Code Reviews
 Chromium Code Reviews Issue 14451003:
  Pretenure ASCII cons string in high promotion mode.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 14451003:
  Pretenure ASCII cons string in high promotion mode.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/heap.h | 
| diff --git a/src/heap.h b/src/heap.h | 
| index b25aa7f612b645a8453f380025a258d5e927a88b..e930713a7b2338c298872d9d63ed835e9acd00e1 100644 | 
| --- a/src/heap.h | 
| +++ b/src/heap.h | 
| @@ -1531,6 +1531,14 @@ class Heap { | 
| return new_space_high_promotion_mode_active_; | 
| } | 
| + inline PretenureFlag GetPretenureMode() { | 
| + return new_space_high_promotion_mode_active_ ? TENURED : NOT_TENURED; | 
| + } | 
| + | 
| + inline Address* NewSpaceHighPromotionModeActiveAddress() { | 
| + return reinterpret_cast<Address*>(&new_space_high_promotion_mode_active_); | 
| + } | 
| + | 
| inline intptr_t PromotedTotalSize() { | 
| return PromotedSpaceSizeOfObjects() + PromotedExternalMemorySize(); | 
| } | 
| @@ -1609,7 +1617,8 @@ class Heap { | 
| static bool RootCanBeWrittenAfterInitialization(RootListIndex root_index); | 
| MUST_USE_RESULT MaybeObject* NumberToString( | 
| - Object* number, bool check_number_string_cache = true); | 
| + Object* number, bool check_number_string_cache = true, | 
| + PretenureFlag pretenure = NOT_TENURED); | 
| MUST_USE_RESULT MaybeObject* Uint32ToString( | 
| uint32_t value, bool check_number_string_cache = true); | 
| @@ -1976,7 +1985,7 @@ class Heap { | 
| // Indicates that the new space should be kept small due to high promotion | 
| // rates caused by the mutator allocating a lot of long-lived objects. | 
| - bool new_space_high_promotion_mode_active_; | 
| + intptr_t new_space_high_promotion_mode_active_; | 
| 
Michael Starzinger
2013/05/03 09:58:21
Can we add a TODO here that this is only "intptr_t
 
Hannes Payer (out of office)
2013/05/03 10:27:32
Done.
 | 
| // Limit that triggers a global GC on the next (normally caused) GC. This | 
| // is checked when we have already decided to do a GC to help determine |