Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1445093002: Revert of Reland "[heap] Turn on parallel compaction" (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "[heap] Turn on parallel compaction" (patchset #1 id:1 of https://codereview.chromium.org/1444283002/ ) Reason for revert: Looks like tasks are still scheduled during isolate shutdown after waiting for remaining tasks: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/5310/ Original issue's description: > Reland "[heap] Turn on parallel compaction" > > This reverts commit e682048027b51dea5b1c9a970e09b8b2a99fcae6. > > BUG=chromium:524425 > LOG=N > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg;tryserver.v8:v8_linux_gc_stress_dbg;tryserver.v8:v8_mac_gc_stress_dbg;tryserver.v8:v8_linux64_msan_rel;tryserver.v8:v8_linux64_tsan_rel > > Committed: https://crrev.com/c82d2323ffd5c399ba37da389ba0cdc72f46c97f > Cr-Commit-Position: refs/heads/master@{#32009} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/aa4688c1852d87223d208b9341e0ebb5127b6cd3 Cr-Commit-Position: refs/heads/master@{#32010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Lippautz
Created Revert of Reland "[heap] Turn on parallel compaction"
5 years, 1 month ago (2015-11-16 15:36:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445093002/1
5 years, 1 month ago (2015-11-16 15:36:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 15:36:25 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 15:36:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa4688c1852d87223d208b9341e0ebb5127b6cd3
Cr-Commit-Position: refs/heads/master@{#32010}

Powered by Google App Engine
This is Rietveld 408576698