Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 1445023002: X87: [turbofan] Better and more sane support for tail calls (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Better and more sane support for tail calls port ff283f7ded84df5a5a77d088e37fd69cf6271a8c (r31987) original commit message: * Limit triggering of tail calls to explicit use of a new inline runtime function %_TailCall. %_TailCall works just like %_Call except for using tail-calling mechanics (currently only in TF). * Remove hack that recognized some specific usages of %_Call and converted them into tail calls. * Support tail calls for all calls where the number of callee stack parameters is less than or equal to the number of caller stack parameters. * Use the gap resolver to swizzle parameters and registers to tail calls. BUG= Committed: https://crrev.com/1dcf534c2c58309a4acedaf95404c38f13443a49 Cr-Commit-Position: refs/heads/master@{#32001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-16 03:13:53 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-16 04:13:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445023002/1
5 years, 1 month ago (2015-11-16 04:13:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 04:31:18 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 04:31:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dcf534c2c58309a4acedaf95404c38f13443a49
Cr-Commit-Position: refs/heads/master@{#32001}

Powered by Google App Engine
This is Rietveld 408576698