Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5822)

Unified Diff: chrome/browser/media/webrtc_logging_handler_host.cc

Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: How many trial and errors before this builds on the Windows bots Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/webrtc_log_uploader.cc ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_logging_handler_host.cc
diff --git a/chrome/browser/media/webrtc_logging_handler_host.cc b/chrome/browser/media/webrtc_logging_handler_host.cc
index ef42d740cb3a198b8d81a650ac6b29faeb90132e..25cb76ea6ee5bc82195e0ec83555373773fa6c8d 100644
--- a/chrome/browser/media/webrtc_logging_handler_host.cc
+++ b/chrome/browser/media/webrtc_logging_handler_host.cc
@@ -312,12 +312,11 @@ void WebRtcLoggingHandlerHost::StoreLogContinue(
ReleaseRtpDumps(log_paths.get());
content::BrowserThread::PostTaskAndReplyWithResult(
- content::BrowserThread::FILE,
- FROM_HERE,
+ content::BrowserThread::FILE, FROM_HERE,
base::Bind(&WebRtcLoggingHandlerHost::GetLogDirectoryAndEnsureExists,
this),
base::Bind(&WebRtcLoggingHandlerHost::StoreLogInDirectory, this, log_id,
- Passed(&log_paths), callback));
+ base::Passed(&log_paths), callback));
}
void WebRtcLoggingHandlerHost::LogMessage(const std::string& message) {
@@ -679,11 +678,12 @@ void WebRtcLoggingHandlerHost::StoreLogInDirectory(
log_paths->log_path = directory;
log_buffer_->SetComplete();
- BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+ BrowserThread::PostTask(
+ BrowserThread::FILE, FROM_HERE,
base::Bind(&WebRtcLogUploader::LoggingStoppedDoStore,
- base::Unretained(g_browser_process->webrtc_log_uploader()),
- *log_paths.get(), log_id, Passed(&log_buffer_), Passed(&meta_data_),
- done_callback));
+ base::Unretained(g_browser_process->webrtc_log_uploader()),
+ *log_paths.get(), log_id, base::Passed(&log_buffer_),
+ base::Passed(&meta_data_), done_callback));
logging_state_ = CLOSED;
}
@@ -700,12 +700,12 @@ void WebRtcLoggingHandlerHost::DoUploadLogAndRtpDumps(
ReleaseRtpDumps(&upload_done_data);
log_buffer_->SetComplete();
- BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE, base::Bind(
- &WebRtcLogUploader::LoggingStoppedDoUpload,
- base::Unretained(g_browser_process->webrtc_log_uploader()),
- Passed(&log_buffer_),
- Passed(&meta_data_),
- upload_done_data));
+ BrowserThread::PostTask(
+ BrowserThread::FILE, FROM_HERE,
+ base::Bind(&WebRtcLogUploader::LoggingStoppedDoUpload,
+ base::Unretained(g_browser_process->webrtc_log_uploader()),
+ base::Passed(&log_buffer_), base::Passed(&meta_data_),
+ upload_done_data));
logging_state_ = CLOSED;
}
« no previous file with comments | « chrome/browser/media/webrtc_log_uploader.cc ('k') | chrome/browser/media/webrtc_rtp_dump_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698