chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc - Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: How many trial and errors before this builds on the Windows bots Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

index d56ed0ca2eac134e953bc1dbca79f75536072ec9..75f104b0bf73f9fafa2e1828c704457d2684375b 100644

--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

@@ -121,11 +121,9 @@ void WebrtcAudioPrivateFunction::GetOutputDeviceNames() {

AudioManager::Get()->GetAudioOutputDeviceNames(device_names.get());

BrowserThread::PostTask(

- BrowserThread::IO,

- FROM_HERE,

- base::Bind(&WebrtcAudioPrivateFunction::OnOutputDeviceNames,

- this,

- Passed(&device_names)));

+ BrowserThread::IO, FROM_HERE,

+ base::Bind(&WebrtcAudioPrivateFunction::OnOutputDeviceNames, this,

+ base::Passed(&device_names)));

}

void WebrtcAudioPrivateFunction::OnOutputDeviceNames(

« no previous file with comments | « chrome/browser/devtools/devtools_network_interceptor.cc ('k') | chrome/browser/media/webrtc_log_uploader.cc » ('j') | no next file with comments »