Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: crypto/scoped_nss_types.h

Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows maybe Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: crypto/scoped_nss_types.h
diff --git a/crypto/scoped_nss_types.h b/crypto/scoped_nss_types.h
index fdfb83c154f8c47996633031c9dcc45abb285e36..8e96e8d4e20ffedb34a529e62ec7e92451bd8c5d 100644
--- a/crypto/scoped_nss_types.h
+++ b/crypto/scoped_nss_types.h
@@ -16,7 +16,6 @@ namespace crypto {
template <typename Type, void (*Destroyer)(Type*)>
struct NSSDestroyer {
- typedef void AllowSelfReset;
danakj 2015/11/17 19:09:27 Can you maybe replace each of these AllowSelfReset
dcheng 2015/11/17 20:21:03 Hmm... that's not really immediately obvious that
davidben 2015/11/17 21:01:45 Part of this change is to remove the self-reset ch
void operator()(Type* ptr) const {
Destroyer(ptr);
}
@@ -24,7 +23,6 @@ struct NSSDestroyer {
template <typename Type, void (*Destroyer)(Type*, PRBool), PRBool freeit>
struct NSSDestroyer1 {
- typedef void AllowSelfReset;
void operator()(Type* ptr) const {
Destroyer(ptr, freeit);
}

Powered by Google App Engine
This is Rietveld 408576698