components/cronet/android/url_request_adapter.cc - Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/url_request_adapter.cc

Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/dbus/fake_modem_messaging_client.cc ('K') | « components/cronet/android/cronet_url_request_context_adapter.cc ('k') | components/memory_pressure/filtered_memory_pressure_calculator.cc » ('j') | content/browser/service_worker/service_worker_process_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/url_request_adapter.cc

diff --git a/components/cronet/android/url_request_adapter.cc b/components/cronet/android/url_request_adapter.cc

index 43fb8f416b98e2d85b79c82ffff70d2d1ced11ec..3195c27ebaabe4b4fe1871331755c5d394a5dcc1 100644

--- a/components/cronet/android/url_request_adapter.cc

+++ b/components/cronet/android/url_request_adapter.cc

@@ -86,11 +86,8 @@ void URLRequestAdapter::AppendChunk(const char* bytes, int bytes_len,

memcpy(buf.get(), bytes, bytes_len);

context_->PostTaskToNetworkThread(

FROM_HERE,

- base::Bind(&URLRequestAdapter::OnAppendChunk,

- base::Unretained(this),

- Passed(buf.Pass()),

- bytes_len,

- is_last_chunk));

+ base::Bind(&URLRequestAdapter::OnAppendChunk, base::Unretained(this),

+ base::Passed(&buf), bytes_len, is_last_chunk));

}

std::string URLRequestAdapter::GetHeader(const std::string& name) const {