Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: rlz/lib/rlz_lib.cc

Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address more comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A library to manage RLZ information for access-points shared 5 // A library to manage RLZ information for access-points shared
6 // across different client applications. 6 // across different client applications.
7 7
8 #include "rlz/lib/rlz_lib.h" 8 #include "rlz/lib/rlz_lib.h"
9 9
10 #include <algorithm>
brettw 2015/11/18 00:21:52 Blank line after this.
dcheng 2015/11/18 18:12:16 Done.
10 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
11 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
12 #include "rlz/lib/assert.h" 13 #include "rlz/lib/assert.h"
13 #include "rlz/lib/crc32.h" 14 #include "rlz/lib/crc32.h"
14 #include "rlz/lib/financial_ping.h" 15 #include "rlz/lib/financial_ping.h"
15 #include "rlz/lib/lib_values.h" 16 #include "rlz/lib/lib_values.h"
16 #include "rlz/lib/rlz_value_store.h" 17 #include "rlz/lib/rlz_value_store.h"
17 #include "rlz/lib/string_utils.h" 18 #include "rlz/lib/string_utils.h"
18 19
19 namespace { 20 namespace {
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 if (cgi_string.size() >= cgi_size) 647 if (cgi_string.size() >= cgi_size)
647 return false; 648 return false;
648 649
649 strncpy(cgi, cgi_string.c_str(), cgi_size); 650 strncpy(cgi, cgi_string.c_str(), cgi_size);
650 cgi[cgi_size - 1] = 0; 651 cgi[cgi_size - 1] = 0;
651 652
652 return true; 653 return true;
653 } 654 }
654 655
655 } // namespace rlz_lib 656 } // namespace rlz_lib
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698