chromeos/dbus/fake_modem_messaging_client.cc - Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/dbus/fake_modem_messaging_client.cc

Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc ('K') | « chrome/browser/ui/views/profiles/user_manager_view.h ('k') | components/autofill/core/browser/personal_data_manager.h » ('j') | content/browser/service_worker/service_worker_process_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chromeos/dbus/fake_modem_messaging_client.h"	5 #include "chromeos/dbus/fake_modem_messaging_client.h"

6	6

	7 #include <algorithm>
	dcheng 2015/11/16 18:22:59 All the lines like this are because people were de All the lines like this are because people were depending on the <algorithm> include in scoped_ptr.h. danakj 2015/11/16 22:19:03 Silly compilers. Show quoted text On 2015/11/16 18:22:59, dcheng wrote: > All the lines like this are because people were depending on the <algorithm> > include in scoped_ptr.h. Silly compilers.
7 #include <string>	8 #include <string>

8 #include <vector>	9 #include <vector>

9	10

10 #include "base/callback.h"	11 #include "base/callback.h"

11 #include "base/logging.h"	12 #include "base/logging.h"

12 #include "dbus/object_path.h"	13 #include "dbus/object_path.h"

13	14

14 namespace chromeos {	15 namespace chromeos {

15	16

16 FakeModemMessagingClient::FakeModemMessagingClient() {}	17 FakeModemMessagingClient::FakeModemMessagingClient() {}

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 message_paths_.push_back(kSmsPath);	55 message_paths_.push_back(kSmsPath);

55 if (!sms_received_handler_.is_null())	56 if (!sms_received_handler_.is_null())

56 sms_received_handler_.Run(kSmsPath, true);	57 sms_received_handler_.Run(kSmsPath, true);

57 callback.Run(no_paths);	58 callback.Run(no_paths);

58 } else {	59 } else {

59 callback.Run(message_paths_);	60 callback.Run(message_paths_);

60 }	61 }

61 }	62 }

62	63

63 } // namespace chromeos	64 } // namespace chromeos

OLD	NEW