Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: chrome/browser/chromeos/app_mode/kiosk_app_manager.h

Issue 1445003002: Use std::default_delete as the default deleter for scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_APP_MANAGER_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_APP_MANAGER_H_
6 #define CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_APP_MANAGER_H_ 6 #define CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_APP_MANAGER_H_
7 7
8 #include <memory>
8 #include <string> 9 #include <string>
9 #include <vector> 10 #include <vector>
10 11
11 #include "base/basictypes.h" 12 #include "base/basictypes.h"
12 #include "base/callback_forward.h" 13 #include "base/callback_forward.h"
13 #include "base/lazy_instance.h" 14 #include "base/lazy_instance.h"
14 #include "base/memory/scoped_ptr.h" 15 #include "base/memory/scoped_ptr.h"
15 #include "base/memory/scoped_vector.h" 16 #include "base/memory/scoped_vector.h"
16 #include "base/observer_list.h" 17 #include "base/observer_list.h"
17 #include "chrome/browser/chromeos/app_mode/kiosk_app_data_delegate.h" 18 #include "chrome/browser/chromeos/app_mode/kiosk_app_data_delegate.h"
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 // kiosk apps that are immediately auto-launched on startup. 222 // kiosk apps that are immediately auto-launched on startup.
222 void SetAppWasAutoLaunchedWithZeroDelay(const std::string& app_id); 223 void SetAppWasAutoLaunchedWithZeroDelay(const std::string& app_id);
223 224
224 // Initialize |app_session_|. 225 // Initialize |app_session_|.
225 void InitSession(Profile* profile, const std::string& app_id); 226 void InitSession(Profile* profile, const std::string& app_id);
226 227
227 AppSession* app_session() { return app_session_.get(); } 228 AppSession* app_session() { return app_session_.get(); }
228 229
229 private: 230 private:
230 friend struct base::DefaultLazyInstanceTraits<KioskAppManager>; 231 friend struct base::DefaultLazyInstanceTraits<KioskAppManager>;
231 friend struct base::DefaultDeleter<KioskAppManager>; 232 friend std::default_delete<KioskAppManager>;
danakj 2015/11/16 22:19:03 This seems like a weird pattern, and I'd expect in
232 friend class KioskAppManagerTest; 233 friend class KioskAppManagerTest;
233 friend class KioskTest; 234 friend class KioskTest;
234 friend class KioskUpdateTest; 235 friend class KioskUpdateTest;
235 236
236 enum AutoLoginState { 237 enum AutoLoginState {
237 AUTOLOGIN_NONE = 0, 238 AUTOLOGIN_NONE = 0,
238 AUTOLOGIN_REQUESTED = 1, 239 AUTOLOGIN_REQUESTED = 1,
239 AUTOLOGIN_APPROVED = 2, 240 AUTOLOGIN_APPROVED = 2,
240 AUTOLOGIN_REJECTED = 3, 241 AUTOLOGIN_REJECTED = 3,
241 }; 242 };
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 base::WeakPtr<KioskAppExternalLoader> secondary_app_external_loader_; 314 base::WeakPtr<KioskAppExternalLoader> secondary_app_external_loader_;
314 315
315 scoped_ptr<AppSession> app_session_; 316 scoped_ptr<AppSession> app_session_;
316 317
317 DISALLOW_COPY_AND_ASSIGN(KioskAppManager); 318 DISALLOW_COPY_AND_ASSIGN(KioskAppManager);
318 }; 319 };
319 320
320 } // namespace chromeos 321 } // namespace chromeos
321 322
322 #endif // CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_APP_MANAGER_H_ 323 #endif // CHROME_BROWSER_CHROMEOS_APP_MODE_KIOSK_APP_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698