Issue 1444943003: Use AbsolutePathContext in Folder.contains().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1444943003: Use AbsolutePathContext in Folder.contains(). (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use AbsolutePathContext in Folder.contains(). This makes MDL analysis about 5% faster, from 5900 samples to 5600 samples. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f464e2eddb285835c5435e09f543f4e5db1445ce

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -15 lines)			Patch
M	pkg/analysis_server/lib/src/context_manager.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/file_system/file_system.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/file_system/memory_file_system.dart	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/file_system/physical_file_system.dart	View	6 chunks	+11 lines, -4 lines	0 comments	Download
M	pkg/analyzer/test/file_system/physical_resource_provider_test.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

scheglov

5 years, 1 month ago (2015-11-15 17:33:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f464e2eddb285835c5435e09f543f4e5db1445ce (presubmit successful).