Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 14449003: Picture element initial implementation (Closed)

Created:
7 years, 8 months ago by Yoav Weiss
Modified:
6 years, 8 months ago
Reviewers:
CC:
blink-reviews, haraken, Nate Chapin, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@picture_after_rebase
Visibility:
Public.

Description

Picture element initial implementation /* This is only here for historic reasons :) This patch is no longer relevant in any way */ BUG=http://crbug.com/233751 Spec=http://www.w3.org/TR/html-picture-element/ Enable a responsive images solution by giving developers control over the image resource that is downloaded & displayed using multiple resources, each with its own media attributes. This implementation is in its initial phase, and doesn't yet represent a complete implementation of the specification.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -38 lines) Patch
A LayoutTests/picture/resources/cake.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/picture/resources/red.png View Binary file 0 comments Download
A LayoutTests/picture/working/picture.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/picture/working/picture-expected.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/picture/working/picture-only-one-resource.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/picture/working/picture-only-one-resource-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/picture/working/picture-only-one-resource-preloaded.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/picture/working/picture-only-one-resource-preloaded-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/picture/working/picture-src.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/picture/working/picture-src-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/platform/chromium-mac/picture/working/picture-only-one-resource-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/platform/chromium-mac/picture/working/picture-only-one-resource-preloaded-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/bindings.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/bindings/v8/custom/V8HTMLPictureElementConstructor.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + Source/bindings/v8/custom/V8HTMLPictureElementConstructor.cpp View 3 chunks +16 lines, -14 lines 0 comments Download
M Source/core/core.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 2 chunks +9 lines, -1 line 0 comments Download
A Source/core/html/HTMLPictureElement.h View 1 chunk +60 lines, -0 lines 0 comments Download
A Source/core/html/HTMLPictureElement.cpp View 1 chunk +105 lines, -0 lines 0 comments Download
A + Source/core/html/HTMLPictureElement.idl View 1 chunk +10 lines, -7 lines 0 comments Download
M Source/core/html/HTMLSourceElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 3 chunks +12 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTagNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 9 chunks +79 lines, -8 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.h View 5 chunks +25 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/page/DOMWindow.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Yoav Weiss
7 years, 8 months ago (2013-04-23 22:57:16 UTC) #1
Following
https://groups.google.com/a/chromium.org/forum/#!topicsearchin/blink-dev/subj...
and despite the NOT LGTM decision on the feature's implementation, I would
highly appreciate if this patch can be reviewed.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698