Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 144483010: Default copies value should be '1'. (Closed)

Created:
6 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Default copies value should be '1'. Print preview renderer expects valid integer in print ticket. According https://developers.google.com/cloud-print/docs/cdd#Copies "copies" :{ } is the same as "copies" :{ "default": 1 } BUG=340342 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/print_preview/data/ticket_items/copies.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 10 months ago (2014-02-03 20:15:22 UTC) #1
Noam Samuel
lgtm
6 years, 10 months ago (2014-02-03 22:20:29 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-03 22:21:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/144483010/1
6 years, 10 months ago (2014-02-03 22:25:29 UTC) #4
commit-bot: I haz the power
Change committed as 248629
6 years, 10 months ago (2014-02-04 00:25:55 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:25:57 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:25:58 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:26:01 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:26:03 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 00:26:04 UTC) #10
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698