Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 144473008: MIPS: Add NaN test to cctest/test-macro-assembler-mips. (Closed)

Created:
6 years, 10 months ago by kilvadyb
Modified:
6 years, 10 months ago
Reviewers:
kisg, Paul Lind, palfia, danno, dusmil
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Add NaN test to cctest/test-macro-assembler-mips. NaN value is different on MIPS and x86 architectures, and TEST(NaNx) tests checks the case where a x86 NaN value is serialized into the snapshot on the simulator during cross compilation. BUG=

Patch Set 1 #

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M test/cctest/test-macro-assembler-mips.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Lind
Can you elaborate in the issue description, and in a comment line in the TestNaN ...
6 years, 10 months ago (2014-02-10 18:10:26 UTC) #1
kilvadyb
6 years, 10 months ago (2014-02-10 19:14:12 UTC) #2
Paul Lind
6 years, 10 months ago (2014-02-10 19:49:50 UTC) #3
Committed as r19241.

Powered by Google App Engine
This is Rietveld 408576698