Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 14447018: Avoid side effects related to skia error callbacks in the testing infrastructure (Closed)

Created:
7 years, 8 months ago by humper
Modified:
7 years, 8 months ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Avoid side effects related to skia error callbacks in the testing infrastructure BUG= Committed: https://code.google.com/p/skia/source/detail?r=8867

Patch Set 1 #

Patch Set 2 : missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tests/Test.cpp View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
humper
7 years, 8 months ago (2013-04-25 18:29:54 UTC) #1
humper
On 2013/04/25 18:29:54, humper wrote: Whoops, premature publish, hold please
7 years, 8 months ago (2013-04-25 18:30:18 UTC) #2
humper
On 2013/04/25 18:30:18, humper wrote: > On 2013/04/25 18:29:54, humper wrote: > > Whoops, premature ...
7 years, 8 months ago (2013-04-25 18:31:09 UTC) #3
scroggo
lgtm
7 years, 8 months ago (2013-04-25 18:33:27 UTC) #4
humper
7 years, 8 months ago (2013-04-25 18:33:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r8867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698