Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: pkg/serialization/lib/src/reader_writer.dart

Issue 14447008: Fix for mirror API breaking change to index libraries by URI, and clean up references in doc commen… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed a print statement, one unsaved fix. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/serialization/lib/src/reader_writer.dart
diff --git a/pkg/serialization/lib/src/reader_writer.dart b/pkg/serialization/lib/src/reader_writer.dart
index 2209f78f42210331b3f6d6efed51a502ae65b101..3569e2f8344ef24e0a0fd08acef57dae5310824e 100644
--- a/pkg/serialization/lib/src/reader_writer.dart
+++ b/pkg/serialization/lib/src/reader_writer.dart
@@ -211,7 +211,8 @@ class Writer implements ReaderOrWriter {
}
/**
- * Return true if the [namedObjects] collection has a reference to [object].
+ * Return true if the [Serialization.namedObjects] collection has a
+ * reference to [object].
*/
// TODO(alanknight): Should the writer also have its own namedObjects
// collection specific to the particular write, or is that just adding
@@ -219,7 +220,8 @@ class Writer implements ReaderOrWriter {
hasNameFor(object) => serialization._hasNameFor(object);
/**
- * Return the name we have for this object in the [namedObjects] collection.
+ * Return the name we have for this object in the [Serialization.namedObjects]
+ * collection.
*/
nameFor(object) => serialization._nameFor(object);
@@ -278,7 +280,7 @@ class Reader implements ReaderOrWriter {
/**
* The resulting objects, indexed according to the same scheme as
- * [data], where each rule has a number, and rules keep track of the objects
+ * [_data], where each rule has a number, and rules keep track of the objects
* that they serialize, in order.
*/
List<List> objects;
@@ -579,7 +581,7 @@ class Reference {
/**
* Convert the reference to a map in JSON format. This is specific to the
* custom JSON format we define, and must be consistent with the
- * [asReference] method.
+ * [Reader.asReference] method.
*/
// TODO(alanknight): This is a hack both in defining a toJson specific to a
// particular representation, and the use of a bogus sentinel "__Ref"

Powered by Google App Engine
This is Rietveld 408576698