Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: pkg/serialization/lib/src/basic_rule.dart

Issue 14447008: Fix for mirror API breaking change to index libraries by URI, and clean up references in doc commen… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed a print statement, one unsaved fix. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/serialization/lib/serialization.dart ('k') | pkg/serialization/lib/src/format.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/serialization/lib/src/basic_rule.dart
diff --git a/pkg/serialization/lib/src/basic_rule.dart b/pkg/serialization/lib/src/basic_rule.dart
index b4a5d4334ac1bfba5ec5b5eb8f7124b84e952af9..16fe6de7d622969353969ed5b25fb18884ef0ccc 100644
--- a/pkg/serialization/lib/src/basic_rule.dart
+++ b/pkg/serialization/lib/src/basic_rule.dart
@@ -224,8 +224,8 @@ class BasicRule extends SerializationRule {
return mirror.reflectee;
}
- /** For all [state] not required in the constructor, set it in the [object],
- * resolving references in the context of [reader].
+ /** For all [rawState] not required in the constructor, set it in the
+ * [object], resolving references in the context of [reader].
*/
inflateNonEssential(rawState, object, Reader reader) {
InstanceMirror mirror = reflect(object);
@@ -284,7 +284,7 @@ abstract class _Field implements Comparable<_Field> {
final _FieldList fieldList;
/**
- * Our position in the [contents] collection of [fieldList]. This is used
+ * Our position in the [fieldList._contents] collection. This is used
* to index into the state, so it's extremely important.
*/
int index;
@@ -332,7 +332,7 @@ abstract class _Field implements Comparable<_Field> {
/**
* Return true if this field is treated as essential state, either because
* it is used in the constructor, or because it's been designated
- * using [setFieldWith].
+ * using [BasicRule.setFieldWith].
*/
bool get isEssential => usedInConstructor;
@@ -377,7 +377,7 @@ class _NamedField extends _Field {
/**
* Return true if this field is treated as essential state, either because
* it is used in the constructor, or because it's been designated
- * using [setFieldWith].
+ * using [BasicRule.setFieldWith].
*/
bool get isEssential => super.isEssential || customSetter != null;
@@ -610,8 +610,8 @@ class Constructor {
/**
* The indices of the fields used as constructor arguments. We will look
- * these up in the state by number. These correspond to the index in the
- * [contents] of the FieldList, which will be alphabetically sorted.
+ * these up in the state by number. These correspond to the index in
+ * [_FieldList._contents], which will be alphabetically sorted.
Jennifer Messerly 2013/04/24 20:23:05 probably don't want to refer to a private member,
Alan Knight 2013/04/25 16:50:18 Done.
*/
List<int> fieldNumbers;
« no previous file with comments | « pkg/serialization/lib/serialization.dart ('k') | pkg/serialization/lib/src/format.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698