LayoutTests/fast/dom/script-tests/constructed-objects-prototypes.js - Issue 14447006: Global constructors should be configurable and not enumerable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/script-tests/constructed-objects-prototypes.js

Issue 14447006: Global constructors should be configurable and not enumerable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Clean rebase on master Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt ('k') | LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/script-tests/constructed-objects-prototypes.js

diff --git a/LayoutTests/fast/dom/script-tests/constructed-objects-prototypes.js b/LayoutTests/fast/dom/script-tests/constructed-objects-prototypes.js

index 034b9252a06020778161cb7f05c99dc7ce010f52..4c83d40d210e8b8dd4c57ce905b22743cbdef977 100644

--- a/LayoutTests/fast/dom/script-tests/constructed-objects-prototypes.js

+++ b/LayoutTests/fast/dom/script-tests/constructed-objects-prototypes.js

@@ -21,8 +21,9 @@ function classNameForObject(object)

function constructorPropertiesOnWindow(globalObject)

{

var constructorNames = [];

- for (var property in globalObject) {

- var value = inner[property];

+ var propertyNames = Object.getOwnPropertyNames(window);

+ for (var i = 0; i < propertyNames.length; i++) {

+ var value = inner[propertyNames[i]];

if (value == null)

continue;

var type = classNameForObject(value);