Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js

Issue 14447006: Global constructors should be configurable and not enumerable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Clean rebase on master Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js
diff --git a/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js b/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js
index 0d8750a842071c4f82eae24a2af07fc73982458f..58c3c8d6d9ca27fa03b18b979d9d41006f1aa52c 100644
--- a/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js
+++ b/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js
@@ -1,17 +1,8 @@
description('Tests that the window.DeviceOrientationEvent and window.ondeviceorientation properties are present.');
-function hasDeviceOrientationEventProperty()
-{
- for (var property in window) {
- if (property == 'DeviceOrientationEvent')
- return true;
- }
- return false;
-}
-
shouldBeTrue("typeof window.DeviceOrientationEvent == 'object'");
shouldBeFalse("typeof window.DeviceOrientationEvent == 'function'");
-shouldBeTrue("hasDeviceOrientationEventProperty()");
+shouldBeFalse("window.propertyIsEnumerable('DeviceOrientationEvent')");
shouldBeTrue("'DeviceOrientationEvent' in window");
shouldBeTrue("window.hasOwnProperty('DeviceOrientationEvent')");
« no previous file with comments | « no previous file | LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698