LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js - Issue 14447006: Global constructors should be configurable and not enumerable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js

Issue 14447006: Global constructors should be configurable and not enumerable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt » ('j') | LayoutTests/fast/dom/script-tests/constructed-objects-prototypes.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js

diff --git a/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js b/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js

index 0d8750a842071c4f82eae24a2af07fc73982458f..e57181f34e0739768f2634d1b66bf284e9b2a34b 100644

--- a/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js

+++ b/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js

@@ -11,7 +11,8 @@ function hasDeviceOrientationEventProperty()

shouldBeTrue("typeof window.DeviceOrientationEvent == 'object'");

shouldBeFalse("typeof window.DeviceOrientationEvent == 'function'");

-shouldBeTrue("hasDeviceOrientationEventProperty()");

+// Global constructors should not be enumerable.

+shouldBeFalse("hasDeviceOrientationEventProperty()");

arv (Not doing code reviews) 2013/04/24 15:34:08 The test on this line is a bit misleading now. May

shouldBeTrue("'DeviceOrientationEvent' in window");

shouldBeTrue("window.hasOwnProperty('DeviceOrientationEvent')");