Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1444643003: Roll GYP 2c1e6cc:70fa8bb (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll GYP 2c1e6cc:70fa8bb This rolls GYP to the latest commit in its repo. The primary reason for the roll is to pick up the change to the analyzer logic in 70fa8bb, but this picks up a few more changes along the way: 70fa8bb Changes semantics of analyzer f54bd19 Adds back lookup of 'all' targets 2dd620e Attempt again to upstream Xcode project version warning suppression, from 1416453003 and 1430573009, and rolled back in 1423583004. 0f5bae1 Change CMAKE_SOURCE_DIR to CMAKE_CURRENT_LIST_DIR BUG=552146 TBR=aharper@chromium.org,ilewis@google.com,dpranke@chromium.org R=dpranke@chromium.org Committed: https://crrev.com/8b15a0583a53ce885f8bfeeb0f1cb8b2e617913c Cr-Commit-Position: refs/heads/master@{#359579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
5 years, 1 month ago (2015-11-13 15:54:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444643003/1
5 years, 1 month ago (2015-11-13 15:55:21 UTC) #3
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-13 17:26:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 17:54:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8b15a0583a53ce885f8bfeeb0f1cb8b2e617913c Cr-Commit-Position: refs/heads/master@{#359579}
5 years, 1 month ago (2015-11-13 17:54:50 UTC) #6
sky
5 years, 1 month ago (2015-11-13 18:40:57 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1446533002/ by sky@chromium.org.

The reason for reverting is: Causing grief on bots..

Powered by Google App Engine
This is Rietveld 408576698