Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 144463016: cc: add more devtools instrumentation (Closed)

Created:
6 years, 10 months ago by caseq
Modified:
6 years, 10 months ago
Reviewers:
danakj, nduca
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, cc-bugs_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

cc: add more devtools instrumentation This adds didRequestMainThreadFrame() and didDrawFrame() so we can better track impl-side frame lifecycle in DevTools R=danakj, nduca Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251127

Patch Set 1 #

Total comments: 1

Patch Set 2 : capitalized instrumentation functions name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M cc/debug/devtools_instrumentation.h View 1 3 chunks +20 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 7 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
caseq
Dana & Nat, please take a look. This is mostly along the lines of the ...
6 years, 10 months ago (2014-02-11 17:27:51 UTC) #1
danakj
Looks OK to me with a style question. *Tosses to Nat* https://codereview.chromium.org/144463016/diff/1/cc/debug/devtools_instrumentation.h File cc/debug/devtools_instrumentation.h (right): ...
6 years, 10 months ago (2014-02-11 17:58:13 UTC) #2
danakj
6 years, 10 months ago (2014-02-11 17:58:16 UTC) #3
caseq
On 2014/02/11 17:58:13, danakj wrote: > https://codereview.chromium.org/144463016/diff/1/cc/debug/devtools_instrumentation.h#newcode106 > cc/debug/devtools_instrumentation.h:106: inline void didDrawFrame(int > layer_tree_host_id) { ...
6 years, 10 months ago (2014-02-11 18:16:28 UTC) #4
caseq
6 years, 10 months ago (2014-02-12 06:30:50 UTC) #5
nduca
lgtm
6 years, 10 months ago (2014-02-12 18:56:43 UTC) #6
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 10 months ago (2014-02-13 16:30:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/144463016/60001
6 years, 10 months ago (2014-02-13 16:30:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/144463016/60001
6 years, 10 months ago (2014-02-13 19:48:03 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 21:28:38 UTC) #10
Message was sent while issue was closed.
Change committed as 251127

Powered by Google App Engine
This is Rietveld 408576698