Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 144463015: [New multicol] Avoid 1px tall multicol if percent height is unresolvable. (Closed)

Created:
6 years, 10 months ago by mstensho (USE GERRIT)
Modified:
6 years, 10 months ago
Reviewers:
ojan
CC:
blink-reviews, mstensho+blink_opera.com, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[New multicol] Avoid 1px tall multicol if percent height is unresolvable. If a box has a percentage height, but the computed height of its containing block is auto, the computed height of the box also becomes auto. computeContentLogicalHeight() returns -1 if the height isn't resolvable, and we need to make sure that such a value doesn't constrain the height of the multicol container. This is a merge of https://bugs.webkit.org/show_bug.cgi?id=122826 Reviewed in WebKit by David Hyatt. BUG=342779 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166974

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
mstensho (USE GERRIT)
6 years, 10 months ago (2014-02-11 16:47:33 UTC) #1
ojan
lgtm
6 years, 10 months ago (2014-02-12 00:27:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/144463015/1
6 years, 10 months ago (2014-02-12 01:59:02 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 07:44:36 UTC) #4
Message was sent while issue was closed.
Change committed as 166974

Powered by Google App Engine
This is Rietveld 408576698