Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: LayoutTests/svg/dom/undefined-null.html

Issue 144463014: Add [StrictTypeChecking] to the SVGGeometryElement interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Drop/change TC; Simplify generated code. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/SVGTransformList-expected.txt ('k') | LayoutTests/svg/dom/undefined-null-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/dom/undefined-null.html
diff --git a/LayoutTests/svg/dom/undefined-null.html b/LayoutTests/svg/dom/undefined-null.html
index 9b55cb382d7a536b8cfed52a611aeb61f6933195..bf69cff1ad86079a50f334f49ce26466fc3761c2 100644
--- a/LayoutTests/svg/dom/undefined-null.html
+++ b/LayoutTests/svg/dom/undefined-null.html
@@ -24,14 +24,14 @@ debug('SVGGeometryElement');
debug('');
debug('isPointInFill(SVGPoint point)');
shouldNotThrow('circle.isPointInFill(point)');
-// shouldThrow('circle.isPointInFill(undefined)'); // CRASH
-// shouldThrow('circle.isPointInFill(null)'); // CRASH
+shouldThrow('circle.isPointInFill(undefined)');
+shouldThrow('circle.isPointInFill(null)');
debug('');
debug('isPointInStroke(SVGPoint point)');
shouldNotThrow('circle.isPointInStroke(point)');
-// shouldThrow('circle.isPointInStroke(undefined)'); // CRASH
-// shouldThrow('circle.isPointInStroke(null)'); // CRASH
+shouldThrow('circle.isPointInStroke(undefined)');
+shouldThrow('circle.isPointInStroke(null)');
debug('');
@@ -41,7 +41,7 @@ debug('SVGSVGElement');
debug('');
debug('getIntersectionList(SVGRect rect, SVGElement? referenceElement)');
shouldNotThrow('svg.getIntersectionList(rect, svg)');
-// shouldThrow('svg.getIntersectionList(undefined, svg)'); // CRASH
+shouldThrow('svg.getIntersectionList(undefined, svg)');
shouldThrow('svg.getIntersectionList(null, svg)');
shouldNotThrow('svg.getIntersectionList(rect, undefined)');
shouldNotThrow('svg.getIntersectionList(rect, null)');
@@ -49,7 +49,7 @@ shouldNotThrow('svg.getIntersectionList(rect, null)');
debug('');
debug('getEnclosureList(SVGRect rect, SVGElement? referenceElement)');
shouldNotThrow('svg.getEnclosureList(rect, svg)');
-// shouldThrow('svg.getEnclosureList(undefined, svg)'); // CRASH
+shouldThrow('svg.getEnclosureList(undefined, svg)');
shouldThrow('svg.getEnclosureList(null, svg)');
shouldNotThrow('svg.getEnclosureList(rect, undefined)');
shouldNotThrow('svg.getEnclosureList(rect, null)');
@@ -57,17 +57,17 @@ shouldNotThrow('svg.getEnclosureList(rect, null)');
debug('');
debug('checkIntersection(SVGElement element, SVGRect rect)');
shouldNotThrow('svg.checkIntersection(svg, rect)');
-// shouldThrow('svg.checkIntersection(undefined, rect)'); // FAIL
+shouldThrow('svg.checkIntersection(undefined, rect)');
shouldThrow('svg.checkIntersection(null, rect)');
-// shouldThrow('svg.checkIntersection(svg, undefined)'); // CRASH
+shouldThrow('svg.checkIntersection(svg, undefined)');
shouldThrow('svg.checkIntersection(svg, null)');
debug('');
debug('checkEnclosure(SVGElement element, SVGRect rect)');
shouldNotThrow('svg.checkEnclosure(svg, rect)');
-// shouldThrow('svg.checkEnclosure(undefined, rect)'); // FAIL
+shouldThrow('svg.checkEnclosure(undefined, rect)');
shouldThrow('svg.checkEnclosure(null, rect)');
-// shouldThrow('svg.checkEnclosure(svg, undefined)'); // CRASH
+shouldThrow('svg.checkEnclosure(svg, undefined)');
shouldThrow('svg.checkEnclosure(svg, null)');
debug('');
@@ -85,7 +85,7 @@ debug('SVGTextContentElement');
debug('');
debug('getCharNumAtPosition(SVGPoint point)');
shouldNotThrow('text.getCharNumAtPosition(point)');
-// shouldThrow('text.getCharNumAtPosition(undefined)'); // CRASH
+shouldThrow('text.getCharNumAtPosition(undefined)');
shouldThrow('text.getCharNumAtPosition(null)');
</script>
« no previous file with comments | « LayoutTests/svg/dom/SVGTransformList-expected.txt ('k') | LayoutTests/svg/dom/undefined-null-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698