Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: Source/bindings/tests/results/V8TestInterfacePython.cpp

Issue 144463014: Add [StrictTypeChecking] to the SVGGeometryElement interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfacePython.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfacePython.cpp b/Source/bindings/tests/results/V8TestInterfacePython.cpp
index 26dbbb5d5607fd8c7f7d7cd3436b8ef07c2fa66f..2d6e6f2330ec72bc397f7d7abbb55626997c4d5c 100644
--- a/Source/bindings/tests/results/V8TestInterfacePython.cpp
+++ b/Source/bindings/tests/results/V8TestInterfacePython.cpp
@@ -691,7 +691,7 @@ static void voidMethodTestInterfaceEmptyArgMethod(const v8::FunctionCallbackInfo
return;
}
TestInterfacePythonImplementation* imp = V8TestInterfacePython::toNative(info.Holder());
- if (info.Length() > 0 && !info[0]->IsUndefined() && !V8TestInterfaceEmpty::hasInstance(info[0], info.GetIsolate())) {
+ if (info.Length() > 0 && (isUndefinedOrNull(info[0]) || !V8TestInterfaceEmpty::hasInstance(info[0], info.GetIsolate()))) {
throwTypeError(ExceptionMessages::failedToExecute("voidMethodTestInterfaceEmptyArg", "TestInterfacePython", "parameter 1 is not of type 'TestInterfaceEmpty'."), info.GetIsolate());
return;
}
@@ -755,7 +755,7 @@ static void implementsComplexMethodMethod(const v8::FunctionCallbackInfo<v8::Val
}
TestInterfacePythonImplementation* imp = V8TestInterfacePython::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[0]);
- if (info.Length() > 1 && !info[1]->IsUndefined() && !V8TestInterfaceEmpty::hasInstance(info[1], info.GetIsolate())) {
+ if (info.Length() > 1 && (isUndefinedOrNull(info[1]) || !V8TestInterfaceEmpty::hasInstance(info[1], info.GetIsolate()))) {
exceptionState.throwTypeError("parameter 2 is not of type 'TestInterfaceEmpty'.");
exceptionState.throwIfNeeded();
return;

Powered by Google App Engine
This is Rietveld 408576698