Add [StrictTypeChecking] to the SVGGeometryElement interface

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 2764 matching lines @@
                 if ($hasExceptionState) {
                     $parameterCheckString .= "        exceptionState.throwTypeError(\"parameter $humanFriendlyIndex (\'\" + string + \"\') is not a valid enum value.\");\n";
                     $parameterCheckString .= "        exceptionState.throwIfNeeded();\n";
                 } else {
                     $parameterCheckString .= "        throwTypeError(ExceptionMessages::failedToExecute(\"$functionName\", \"$interfaceName\", \"parameter $humanFriendlyIndex (\'\" + string + \"\') is not a valid enum value.\"), info.GetIsolate());\n";
                 }
                 $parameterCheckString .= "        return;\n";
                 $parameterCheckString .= "    }\n";
             }
         } else {
             # If the "StrictTypeChecking" extended attribute is present, and the argument's type is an

[Nils Barth (inactive), 2014/02/12 01:15:45]

Could you rewrite this comment to be explicit about what happens for undefined
and null?

# If the [StrictTypeChecking] extended attribute is present, type
# check interface type arguments for correct type and nullability.
#
# If the argument is passed, and is not |undefined| or |null|, then
# it must implement the interface type, otherwise throw a TypeError
# If the parameter is nullable, then both |undefined| and |null|
# pass a NULL pointer to the C++ code, otherwise these also throw.
# Without [StrictTypeChecking], in all these cases NULL is silently
# passed to the C++ code.
#
# Per the Web IDL and ECMAScript specifications, incoming values
# can always be converted to primitive types and strings (including
# |undefined| and |null|), so do not throw TypeError for these.

[fs, 2014/02/12 10:07:27]

Done.

             # interface type, then if the incoming value does not implement that interface, a TypeError
             # is thrown rather than silently passing NULL to the C++ code.
             # Per the Web IDL and ECMAScript specifications, incoming values can always be converted
             # to both strings and numbers, so do not throw TypeError if the argument is of these
             # types.
             if ($function->extendedAttributes->{"StrictTypeChecking"} || $interface->extendedAttributes->{"StrictTypeChecking"}) {
                 my $argValue = "info[$paramIndex]";
                 my $argType = $parameter->type;
                 if (IsWrapperType($argType)) {
-                    my $undefinedNullCheck = $parameter->isNullable ? "isUndefinedOrNull($argValue)" : "${argValue}->IsUndefined()";
-                    $parameterCheckString .= "    if (info.Length() > $paramIndex && !$undefinedNullCheck && !V8${argType}::hasInstance($argValue, info.GetIsolate())) {\n";
+                    my $undefinedNullCheck = $parameter->isNullable ? "!isUndefinedOrNull($argValue) &&" : "isUndefinedOrNull($argValue) ||";
+                    $parameterCheckString .= "    if (info.Length() > $paramIndex && ($undefinedNullCheck !V8${argType}::hasInstance($argValue, info.GetIsolate()))) {\n";
                     if ($hasExceptionState) {
                         $parameterCheckString .= "        exceptionState.throwTypeError(\"parameter $humanFriendlyIndex is not of type \'$argType\'.\");\n";
                         $parameterCheckString .= "        exceptionState.throwIfNeeded();\n";
                     }else {
                         $parameterCheckString .= "        throwTypeError(ExceptionMessages::failedToExecute(\"$functionName\", \"$interfaceName\", \"parameter $humanFriendlyIndex is not of type \'$argType\'.\"), info.GetIsolate());\n";
                     }
                     $parameterCheckString .= "        return;\n";
                     $parameterCheckString .= "    }\n";
                 }
             }
@@ skipping 3672 matching lines @@
         if ($parameter->type eq "SerializedScriptValue") {
             return 1;
         } elsif (IsIntegerType($parameter->type)) {
             return 1;
         }
     }
     return 0;
 }
 
 1;