LayoutTests/svg/dom/SVGGeometryElement.html - Issue 144463014: Add [StrictTypeChecking] to the SVGGeometryElement interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/dom/SVGGeometryElement.html

Issue 144463014: Add [StrictTypeChecking] to the SVGGeometryElement interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!doctype html>
	Nils Barth (inactive) 2014/02/12 03:29:51 Style notes: http://www.w3.org/TR/html5/syntax.htm Style notes: http://www.w3.org/TR/html5/syntax.html http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml <!DOCTYPE html> (it's case insensitive, but conventionally uppercase.) fs 2014/02/12 10:07:27 Done. Show quoted text On 2014/02/12 03:29:51, Nils Barth wrote: > Style notes: > http://www.w3.org/TR/html5/syntax.html > http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml > <!DOCTYPE html> > (it's case insensitive, but conventionally uppercase.) Done.
	2 <title>SVGGeometryElement</title>

	3 <svg><rect/></svg>
	Nils Barth (inactive) 2014/02/12 03:29:51 <rect></rect> not <rect/> (no self-closing tags in <rect></rect> not <rect/> (no self-closing tags in HTML5, so <rect/> is equivalent to <rect>, and <rect> should be closed, since it otherwise can have contents; I don't believe its end tag is optional.) fs 2014/02/12 10:07:27 Done. Show quoted text On 2014/02/12 03:29:51, Nils Barth wrote: > <rect></rect> not <rect/> > (no self-closing tags in HTML5, so <rect/> is equivalent to <rect>, > and <rect> should be closed, since it otherwise can have contents; > I don't believe its end tag is optional.) Done.
	4 <script src=../../resources/js-test.js></script>
	Nils Barth (inactive) 2014/02/12 03:29:51 We conventionally quote this, with double quotes. We conventionally quote this, with double quotes. Also usually put this script in the head. fs 2014/02/12 10:07:27 Done. Show quoted text On 2014/02/12 03:29:51, Nils Barth wrote: > We conventionally quote this, with double quotes. > Also usually put this script in the head. Done.
	5 <script>

	6 var rect = document.querySelector('rect');

	7 shouldThrow("rect.isPointInFill(null)");
	Nils Barth (inactive) 2014/02/12 03:29:51 Single quotes in JavaScript. Single quotes in JavaScript. fs 2014/02/12 10:07:27 Done. Show quoted text On 2014/02/12 03:29:51, Nils Barth wrote: > Single quotes in JavaScript. Done.
	8 shouldThrow("rect.isPointInFill(undefined)");

	9 shouldThrow("rect.isPointInStroke(null)");

	10 shouldThrow("rect.isPointInStroke(undefined)");

	11 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/dom/SVGGeometryElement-expected.txt » ('j') | Source/bindings/scripts/code_generator_v8.pm » ('J')