third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 1444493002: Fix hard-coding of "about:srcdoc"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 1444493002: Fix hard-coding of "about:srcdoc" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index b6431fd77b1903f29f7237eec214393903112ffa..deaefcccb5d05c8da452ebc74e6178f2d5d0a5f0 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -1454,7 +1454,7 @@ bool FrameLoader::shouldTreatURLAsSameAsCurrent(const KURL& url) const

bool FrameLoader::shouldTreatURLAsSrcdocDocument(const KURL& url) const

{

- if (!equalIgnoringCase(url.string(), "about:srcdoc"))

+ if (!url.isAboutSrcdocURL())

return false;

HTMLFrameOwnerElement* ownerElement = m_frame->deprecatedLocalOwner();

if (!isHTMLIFrameElement(ownerElement))