Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 1444493002: Fix hard-coding of "about:srcdoc" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 28d99d964d16b432e27c8878e60e5c31b3d20acc..3a5fa690bfb12454f58943e0c59ba1a7067b1b69 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -1458,7 +1458,7 @@ bool FrameLoader::shouldTreatURLAsSameAsCurrent(const KURL& url) const
bool FrameLoader::shouldTreatURLAsSrcdocDocument(const KURL& url) const
{
- if (!equalIgnoringCase(url.string(), "about:srcdoc"))
+ if (!equalIgnoringCase(url, srcdocURL()))
Tom Sepez 2015/11/16 17:16:06 Shouldn't this be url.isAboutSrcDocUrl() ? We now
Xiaocheng 2015/11/17 05:25:47 Done.
return false;
HTMLFrameOwnerElement* ownerElement = m_frame->deprecatedLocalOwner();
if (!isHTMLIFrameElement(ownerElement))

Powered by Google App Engine
This is Rietveld 408576698