Unify desktop and Android tab helper instantiation.

Unify desktop and Android tab helper instantiation.

BUG=337600
TEST=zero visible change

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247676

Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=247682

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248073

[Avi (use Gerrit), 2014-01-25 23:44:35]

Yaron—

I replicated the tab_android code by #ifdef-ing out anything that wasn't in
tab_android. I'm pretty sure I did that right, but what I don't know is whether,
over the years, people forgot to include tab helpers for Android that they
shouldn't have.

Can you look over the list of tab helpers that are ifdef-ed out for Android and
verify that list? Make sure that none of them really are needed?

[Yaron, 2014-01-27 19:43:13]

I have audited the list previously and it was fine. Looks like the exclusions
are still correct. lgtm and thanks -- sorry this fell off my radar

https://codereview.chromium.org/144443003/diff/160001/chrome/browser/ui/tab_h...
File chrome/browser/ui/tab_helpers.h (right):

https://codereview.chromium.org/144443003/diff/160001/chrome/browser/ui/tab_h...
chrome/browser/ui/tab_helpers.h:24: // A "tab contents" is a WebContents that is
used as a tab in a browser window,
this isn't entirely accurate on android (there's no tab strip model). I don't
know if you care to say something like: "On Android, these are owned by
TabAndroid and managed by TabModel"

[Avi (use Gerrit), 2014-01-27 19:59:44]

John, can you stamp this? Yaron OKed the real changes of the merge; the rest is
simple renaming.

[jam, 2014-01-27 21:38:03]

lgtm

[commit-bot: I haz the power, 2014-01-27 21:53:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/144443003/230001

[commit-bot: I haz the power, 2014-01-28 00:11:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/144443003/230001

[commit-bot: I haz the power, 2014-01-28 20:12:02]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2014-01-28 20:48:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/144443003/230001

[commit-bot: I haz the power, 2014-01-29 05:32:57]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2014-01-29 05:58:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/144443003/230001

[commit-bot: I haz the power, 2014-01-29 11:39:58]

Change committed as 247676

[cimamoglu (inactive), 2014-01-29 13:36:25]

A revert of this CL has been created in
https://codereview.chromium.org/149393004/ by cimamoglu@chromium.org.

The reason for reverting is: This causes Clank to crash at startup, and makes
tests fail
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/11575

Tried the revert locally, and Clank started normally..

[commit-bot: I haz the power, 2014-01-30 19:05:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/144443003/250001

[commit-bot: I haz the power, 2014-01-30 22:10:29]

Retried try job too often on win_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-30 22:10:44]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 22:13:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/144443003/250001

[commit-bot: I haz the power, 2014-01-30 23:43:02]

Change committed as 248073

[commit-bot: I haz the power, 2014-01-30 23:43:15]

CQ bit was unchecked on CL. Ignoring.