Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1444423002: MIPS64: [turbofan] Combine untagging shifts with Mul, Div and Mod. (Closed)

Created:
5 years, 1 month ago by dusan.milosavljevic
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: [turbofan] Combine untagging shifts with Mul, Div and Mod. TEST=unittests/InstructionSelectorTest.CombineShiftsWithMul, InstructionSelectorTest.CombineShiftsWithDivMod BUG= Committed: https://crrev.com/5d843f26a962a58e5669152f149d701819132d41 Cr-Commit-Position: refs/heads/master@{#32061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -7 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 5 chunks +48 lines, -7 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dusan.milosavljevic
PTAL.
5 years, 1 month ago (2015-11-16 18:29:43 UTC) #2
paul.l...
LGTM.
5 years, 1 month ago (2015-11-17 21:32:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444423002/1
5 years, 1 month ago (2015-11-17 22:35:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 22:52:29 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 22:53:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d843f26a962a58e5669152f149d701819132d41
Cr-Commit-Position: refs/heads/master@{#32061}

Powered by Google App Engine
This is Rietveld 408576698