third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl - Issue 1444303002: [webnfc] Align NFC interface with latest specification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl

Issue 1444303002: [webnfc] Align NFC interface with latest specification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes for review comments from Kenneth Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/nfc/NFC.h ('K') | « third_party/WebKit/Source/modules/nfc/NFCMessage.idl ('k') | third_party/WebKit/Source/modules/nfc/NFCRecord.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl

diff --git a/third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl b/third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl

index 2fe24e8115913e0cca118045932bcf46327cd15b..c7c78fb543d0106faa9ffa318893ae81da6196e6 100644

--- a/third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl

+++ b/third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl

@@ -2,11 +2,12 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// https://w3c.github.io/web-nfc/index.html#the-nfcpushoptions-dictionary

+// https://w3c.github.io/web-nfc/#the-nfcpushoptions-dictionary

-enum NFCPushTarget { "tag", "peer" };

+enum NFCPushTarget { "tag", "peer", "any" };

dictionary NFCPushOptions {

- NFCPushTarget target;

- unsigned long timeout;

+ NFCPushTarget target = "any";

+ unrestricted double timeout; // in ms

+ boolean ignoreRead = true;

};