Get rid of usages of ScriptWrappable::wrapper().

Source/bindings/v8/UnsafePersistent.h

 /*
- * Copyright (C) 2013 Google Inc.  All rights reserved.
+ * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef HTMLParserThread_h
-#define HTMLParserThread_h
+#ifndef UnsafePersistent_h
+#define UnsafePersistent_h
 
-#include <wtf/Functional.h>
-#include <wtf/MessageQueue.h>
-#include <wtf/PassOwnPtr.h>
-#include <wtf/PassRefPtr.h>
-#include <wtf/Threading.h>
+#include <v8.h>
 
 namespace WebCore {
 
-// FIXME:: Closure is the Chromium-name for Function<void()>, but we may want something else for WebCore.
-typedef Function<void()> Closure;
+// An unsafe way to pass Persistent handles around. Do not use unless you know
+// what you're doing. UnsafePersistent is only safe to use when we know that the
+// memory pointed by the it is not going away: 1) When GC cannot happen while
+// the UnsafePersistent is alive or 2) when there is a strong Persistent keeping

[haraken, 2013/04/29 10:42:17]

Would you add an ASSERT() that checks that GC has never happened during the
lifetime of the UnsafePersistent? You can add a flag in V8GCController (e.g.
V8GCController::gc_observed_flag_).

[marja, 2013/04/29 12:02:07]

Can't be a bool, because we wouldn't know when to reset it (and there might be
multiple UnsafePersistents around...), but added a counter.

+// the memory alive while the UnsafePersistent is alive.
+template<typename T> class UnsafePersistent {
+public:
+    UnsafePersistent(T* value) : m_value(value) { }
 
-class HTMLParserThread {
-public:
-    static PassOwnPtr<HTMLParserThread> create()
+    // The end result is generally unsafe to use, see the class level comment
+    // for when it's safe to use.
+    void makePersistentHandle(v8::Persistent<T>* handle) const
     {
-        return adoptPtr(new HTMLParserThread());
+        T** rawValue = reinterpret_cast<T**>(handle);
+        *rawValue = m_value;
     }
-    ~HTMLParserThread();
 
-    static HTMLParserThread* shared();
-
-    bool start();
-    void stop();
-
-    void postTask(const Closure&);
-
-    ThreadIdentifier threadId() const { return m_threadID; }
+    T* value() const

[dcarney, 2013/04/29 10:33:51]

is this needed?

[marja, 2013/04/29 12:02:07]

This is used for constructing the UniqueId.

+    {
+        return m_value;
+    }
 
 private:
-    HTMLParserThread();
-
-    static void threadStart(void*);
-    void runLoop();
-
-    Mutex m_threadCreationMutex;
-    MessageQueue<Closure> m_queue;
-    ThreadIdentifier m_threadID;
+    T* m_value;
 };
 
-} // namespace WebCore
 
-#endif // HTMLParserThread_h
+
+
+}
+
+#endif