Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 14443003: D-Bus: notify properties changed from fakes (Closed)

Created:
7 years, 8 months ago by keybuk
Modified:
7 years, 8 months ago
Reviewers:
youngki, satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, deymo
Visibility:
Public.

Description

D-Bus: notify properties changed from fakes Call the property changed callback when fakes use ReplaceValue() or ReplaceValueWithSetValue(), since the actual implementation will always call the callback. This avoids issues with property changed notifications being missing when properties structures are built within fakes. BUG=none TEST=dbus_unittests, device_unittests R=satorux@chromium.org, youngki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M chromeos/dbus/bluetooth_adapter_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_adapter_client.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_device_client.cc View 9 chunks +21 lines, -19 lines 0 comments Download
M dbus/property.h View 1 chunk +8 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_experimental_chromeos_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
keybuk
7 years, 8 months ago (2013-04-23 20:30:49 UTC) #1
satorux1
LGTM
7 years, 8 months ago (2013-04-23 21:10:13 UTC) #2
youngki
lgtm
7 years, 8 months ago (2013-04-23 21:41:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/14443003/1
7 years, 8 months ago (2013-04-23 21:42:14 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=32444
7 years, 8 months ago (2013-04-24 00:45:14 UTC) #5
keybuk
7 years, 8 months ago (2013-04-24 01:42:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r195977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698